fix(spur-tests): remove unused imports and variables#158
Merged
shiv-tyagi merged 1 commit intoROCm:mainfrom May 7, 2026
Merged
fix(spur-tests): remove unused imports and variables#158shiv-tyagi merged 1 commit intoROCm:mainfrom
shiv-tyagi merged 1 commit intoROCm:mainfrom
Conversation
Drop unused HashMap, Arc, JobId, and partition imports from the test harness and scheduler tests. Mark job binding as immutable in GPU test.
There was a problem hiding this comment.
Pull request overview
Cleans up the spur-tests crate by removing unused imports and making a GPU test job binding immutable, reducing warnings and keeping test code minimal.
Changes:
- Removed unused
HashMap,Arc, andJobIdimports from the test harness. - Removed an unused
partition::*import from scheduler tests. - Changed a GPU test’s
jobbinding frommutto immutable.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/spur-tests/src/t39_gpu.rs | Makes the test job binding immutable where it is not mutated. |
| crates/spur-tests/src/t07_sched.rs | Drops an unused partition module import from scheduler tests. |
| crates/spur-tests/src/harness.rs | Removes unused std/core imports from the test harness module. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Reviewed myself and with copilot. Looking good. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop unused HashMap, Arc, JobId, and partition imports from the test harness and scheduler tests. Mark job binding as immutable in GPU test.